-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Backends: Win32: dynamically load XInput library #3646
Conversation
Thank you @Demonese. I noticed your fixed the batch file, thanks! This was indeed overlooked by b1a18d8 and I've now fixed it with 3346544 (your PR will conflict because of it, but you can remove the modification to the .bat file and rebase over master + force push if you want, otherwise I'll do it when merging). I think if you keep Thanks again! |
f3e83b2
to
5389aaf
Compare
13eccbe
to
18a12eb
Compare
@ocornut Ok, it's all right now. I will keep this PR up to date because my project is using this improvement. |
0ae6692
to
228a697
Compare
125028f
to
4a8c505
Compare
4a8c505
to
4e589f5
Compare
eb43ce7
to
6d2c7be
Compare
6d2c7be
to
b18a5d2
Compare
😋I refer to GLFW's implementation and added searches for XInput1_1.dll and XInput1_2.dll. I also added some cleanup code (line 151-155, maybe you forgot them? @ocornut ): |
See: #3645
Related Pull Request:#3248