Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing a crash in the wgpu backend when ClipRect is unclipped #7191

Closed
wants to merge 1 commit into from
Closed

Fixing a crash in the wgpu backend when ClipRect is unclipped #7191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backends/imgui_impl_wgpu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,14 @@ void ImGui_ImplWGPU_RenderDrawData(ImDrawData* draw_data, WGPURenderPassEncoder
ImVec2 clip_max((pcmd->ClipRect.z - clip_off.x) * clip_scale.x, (pcmd->ClipRect.w - clip_off.y) * clip_scale.y);
if (clip_max.x <= clip_min.x || clip_max.y <= clip_min.y)
continue;

// When opening a popup, the clip_min/clip_max are 1-pixel bigger which causes an issue in the wgpuRenderPassEncoderSetScissorRect later.
// Clamping to the framebuffer size does the trick.
ImVec2 FramebufferSize(draw_data->DisplaySize.x * draw_data->FramebufferScale.x, draw_data->DisplaySize.y * draw_data->FramebufferScale.y);
if (clip_min.x < 0) clip_min.x = 0;
if (clip_min.y < 0) clip_min.y = 0;
if (clip_max.x > FramebufferSize.x) clip_max.x = FramebufferSize.x;
if (clip_max.y > FramebufferSize.y) clip_max.y = FramebufferSize.y;

// Apply scissor/clipping rectangle, Draw
wgpuRenderPassEncoderSetScissorRect(pass_encoder, (uint32_t)clip_min.x, (uint32_t)clip_min.y, (uint32_t)(clip_max.x - clip_min.x), (uint32_t)(clip_max.y - clip_min.y));
Expand Down