Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Regression in ocropus-gpageseg #251

Closed
jze opened this issue Oct 16, 2017 · 4 comments
Closed

Regression in ocropus-gpageseg #251

jze opened this issue Oct 16, 2017 · 4 comments

Comments

@jze
Copy link
Contributor

jze commented Oct 16, 2017

The changes between rev 2e83dcb and 8d378ab caused a regression in ocropus-gpageseg. The older version produces a line like this:
good nrm

With the new version a line includes some pixels from the next line:
bad nrm
@stweil
Copy link
Contributor

stweil commented Oct 16, 2017

Could you try to narrow it down to the commit which causes the regression by using git bisect?

@jze
Copy link
Contributor Author

jze commented Oct 16, 2017 •
edited
Loading

2e83dcb and 8d378ab are consecutive commits for ocropus-gpageseg

@stweil
Copy link
Contributor

stweil commented Oct 16, 2017 •
edited
Loading

Yes, but 8d378ab merged several commits. How can I reproduce the problem myself? Does a154e63 work?

zuphilip added a commit that referenced this issue Oct 17, 2017
@zuphilip
Merge pull request #252 from jze/gpageseg
ebd8235 
Fix regression in ocropus-gpageseg #251
@zuphilip
Copy link
Collaborator

Fixed in #252

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jze @zuphilip @stweil