Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Unit tests #209

Merged
merged 2 commits into from
May 8, 2017
Merged

Unit tests #209

merged 2 commits into from
May 8, 2017

Conversation

zuphilip
Copy link
Collaborator

@zuphilip zuphilip commented Apr 29, 2017 •
edited
Loading

Make sure that unit tests are tested during CI.

@zuphilip zuphilip requested a review from kba May 8, 2017 05:52
kba
kba approved these changes May 8, 2017
View reviewed changes
Copy link
Collaborator

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the return 0 statements and if the tests grow more complex, it might be a good idea to factor out the TAP-emitting or switch to unittests or similar but for now LGTM.

@zuphilip
Copy link
Collaborator Author

zuphilip commented May 8, 2017

You don't need the return 0 statements

Okay, I guess this is is the standard behavior then...

... if the tests grow more complex, it might be a good idea to factor out the TAP-emitting or switch to unittests or similar but for now LGTM.

Yes, this are good ideas to continue to work on unit tests. Let us keep that in mind when we expand the unit tests here.

@zuphilip zuphilip merged commit c5bfbf4 into master May 8, 2017
@zuphilip zuphilip deleted the unit-tests branch May 8, 2017 18:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuphilip @kba