-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add a new meta schema keyword: family, to group related classes in a category #1334
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
…favor of an updated email_activity class. Updated the email object to include domains, files, urls arrays. Updated the email_activity class to add the message_trace_uid ID. Updated the email_activity class to use the references[] for the Trace activity_id instead of the description URL. Updated the email_activity class description to reflect its SMTP protocol and the possible URLs and files attachments. Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
…on to fail!! Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
…ed an at_least_one constraint on all the to and from attributes. Not all email logs have the 'to' and 'from' but must have at least those or 'smtp_to' and 'smtp_from' in the log. Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
…egory. Updated the Discovery classes with their families of Query, Inventory, State. Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
…_famil Add back changes for the family keywords to conflicting classes for Discoveryy Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
…into event_family
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question: other categorization schemes in OCSF, like group
and requirement
for attributes are lower-case. Should family
be as well? For this use case at least, it seems more like an enum than a description.
Yes, the intent was for it to be similar to |
Related Issue: #1261
Description of changes:
Added a new meta schema keyword called
family
which like thegroup
keyword does with attributes, can tag related event classes. This could be used to organize related classes in a category that don't have contiguous IDs, which cause them to sort randomly as the classes have been created in time. A large number of classes in a category can also be collapsed into a label, as another example (e.g. a large list of OT protocols in the Network category).Delete once you have confirmed the following:
Unreleased
section in the CHANGELOG.md file?