Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bug fixes #112

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Bug fixes #112

merged 3 commits into from
Oct 11, 2024

Conversation

floydtree
Copy link
Contributor

Issues Addressed:

  1. timestamp_t values generated by website samples incorrect #110
    • Updating the timestamp precision used in sample data generation to millisecs, originally microsec was used which is inconsistent with OCSF's definition of the field.
  2. JSON schema improvements - Add constraints, enum values #109 (Partially)
    • Adding the missing additionalProperties flag to the JSON schema

@floydtree
fixing sample data generation for timestamp fields
533e313 
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
@floydtree
setting additional properties to false in the json schemas
ede12f7 
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
@floydtree
updating the version
9b85400 
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
@rmouritzen-splunk rmouritzen-splunk merged commit 0481e84 into ocsf:main Oct 11, 2024
1 check passed
@floydtree floydtree deleted the bug_fixes branch October 21, 2024 16:23
@floydtree floydtree mentioned this pull request Oct 21, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rmouritzen-splunk rmouritzen-splunk rmouritzen-splunk approved these changes

@mikeradka mikeradka Awaiting requested review from mikeradka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floydtree @rmouritzen-splunk