Do more aggressive lambda lifting #1886
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierNicole
force-pushed
the
more-lambda-lifting
branch
from
97f8d5f to
6f67ac7
Compare
vouillon
force-pushed
the
more-lambda-lifting
branch
2 times, most recently
from
83fff63 to
418e0ed
Compare
OlivierNicole
force-pushed
the
more-lambda-lifting
branch
from
418e0ed to
580b603
Compare
vouillon
force-pushed
the
more-lambda-lifting
branch
from
580b603 to
e76cef3
Compare
OlivierNicole
force-pushed
the
more-lambda-lifting
branch
from
e76cef3 to
b59bd3e
Compare
With @vouillon we realized that the `Lambda_lifting_simple` pass that is performed by double translation makes some programs significantly faster. We measured roughly a 1.45 speedup on a large (proprietary) Bonsai benchmark. Presumably V8 is much faster with more toplevel functions and less nested closures.
vouillon
force-pushed
the
more-lambda-lifting
branch
from
b59bd3e to
25929ef
Compare
|
This seems to result in a modest speedup on average, including on |
No, I'm using a workaround. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @vouillon we realized that the
Lambda_lifting_simplepass that is performed by double translation makes some programs significantly faster. We measured roughly a 1.45 speedup on a large (proprietary) Bonsai benchmark. Presumably V8 is much faster with more toplevel functions and less nested closures.Making this a draft PR for now because:
We probably need to do some measurements before merging. (And maybe with other engines.)