Skip to content

More benchmarks #1899

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 7, 2025
Merged

More benchmarks #1899

merged 7 commits into from
Apr 7, 2025

Conversation

vouillon
Copy link
Member

No description provided.

@vouillon vouillon force-pushed the more-benchmarks branch 5 times, most recently from a894bb5 to b9e9274 Compare March 25, 2025 15:43
@vouillon vouillon marked this pull request as ready for review March 25, 2025 21:08
@vouillon vouillon marked this pull request as draft March 25, 2025 22:00
@vouillon vouillon force-pushed the more-benchmarks branch 3 times, most recently from 616d644 to 5407124 Compare March 26, 2025 16:50
@vouillon vouillon marked this pull request as ready for review March 26, 2025 16:50
@OlivierNicole
Copy link
Contributor

For some reasons the benchmarks results don’t show in the logs.

@vouillon
Copy link
Member Author

For some reasons the benchmarks results don’t show in the logs.

Are you looking at the right place?
https://bench.ci.dev/ocsigen/js_of_ocaml/pull/1899/base/master/benchmark/Wasm_of_ocaml

@OlivierNicole
Copy link
Contributor

Apparently not. I was tripped on the fact that clicking on a benchmark set resets the PR selection.

@vouillon
Copy link
Member Author

Apparently not. I was tripped on the fact that clicking on a benchmark set resets the PR selection.

Yes, that's confusing.

@vouillon vouillon force-pushed the more-benchmarks branch 3 times, most recently from f88c4b7 to a3409b3 Compare April 3, 2025 16:25
@OlivierNicole
Copy link
Contributor

There seems to still be ppxlib-related issues in the benchmarking CI…

@vouillon vouillon force-pushed the more-benchmarks branch 6 times, most recently from 5dad0d2 to 33c00a6 Compare April 4, 2025 13:36
OlivierNicole
OlivierNicole reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@OlivierNicole OlivierNicole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Should we wait for the benchmarking server to work again before merging?

@vouillon
Copy link
Member Author

vouillon commented Apr 4, 2025

Let's wait. I have not seen the result of my latest changes.

@OlivierNicole
Copy link
Contributor

(The benchmarking server looks like it’s in a better state now.)

@OlivierNicole
Copy link
Contributor

Some benchmarks results have “?” as a result still.

@vouillon
Copy link
Member Author

vouillon commented Apr 7, 2025

Some benchmarks results have “?” as a result still.

I think this is because the result or the metric has been renamed.

@OlivierNicole
Copy link
Contributor

In that case, feel free to merge.

@vouillon vouillon merged commit 3ca0d2e into master Apr 7, 2025
0 of 30 checks passed
@vouillon vouillon deleted the more-benchmarks branch April 7, 2025 13:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@OlivierNicole OlivierNicole

Assignees
No one assigned
Labels
no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vouillon @OlivierNicole