Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check wasmoo js runtime #1909

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check wasmoo js runtime #1909

wants to merge 2 commits into from

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Mar 30, 2025

No description provided.

@hhugo hhugo requested a review from vouillon March 30, 2025 12:22
@@ -396,7 +396,7 @@
return caml_alloc_times(t.user / 1e6, t.system / 1e6);
} else {
var t = performance.now() / 1000;
return call_alloc_times(t, t);
return caml_alloc_times(t, t);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bugfix

@vouillon
Copy link
Member

I was planning on adding more structure on the file generated by gen.ml, not less, to support multiple precompiled runtimes:
0358924#diff-a343086c1e25da51180175ccb77f6c7726317f75db5e020e56f4b6061f7b5ac3
I'm not sure how your changes fit.

| ('a' .. 'z' | 'A' .. 'Z') as i -> i
| _ -> '_')
in
name_ident, fname, read_file fname)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name_ident, fname, read_file fname)
name_ident, fname, Fs.read_file fname)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants