Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG]: dist-types/index.d.ts is not present in the published NPM package #525

Closed
1 task done
wolfy1339 opened this issue Apr 19, 2023 · 2 comments · Fixed by #526
Closed
1 task done

[BUG]: dist-types/index.d.ts is not present in the published NPM package #525

wolfy1339 opened this issue Apr 19, 2023 · 2 comments · Fixed by #526
Labels
released Type: Bug Something isn't working as documented, or is being fixed

Comments

@wolfy1339
Copy link
Member

wolfy1339 commented Apr 19, 2023 •
edited
Loading

What happened?

The dist-types folder is not getting published to npm

Apparently, since npm 9 the file pattern matching for npm publish has changed, but nothing was reported in their Changelog (I'm assuming it's an unintended change).

Versions

@octokit/types 9.1.0

Relevant log output

N/A

Code of Conduct

  • I agree to follow this project's Code of Conduct
@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented, or is being fixed Priority: High labels Apr 19, 2023
@wolfy1339 wolfy1339 mentioned this issue Apr 19, 2023
Merged
@wolfy1339 wolfy1339 transferred this issue from octokit/openapi-types.ts Apr 19, 2023
This was referenced Apr 19, 2023
Merged
Merged
wolfy1339 added a commit that referenced this issue Apr 20, 2023
@wolfy1339
fix(build): add script to fix package json from build step
7ec0ee9 
Fixes #525
@wolfy1339 wolfy1339 mentioned this issue Apr 20, 2023
Merged
5 tasks
@kachick kachick mentioned this issue Apr 20, 2023
Closed
Jason3S added a commit to streetsidesoftware/cspell that referenced this issue Apr 20, 2023
@Jason3S
chore: Update dependencies
6ba4e01 
Lock `@octokit/types` due to issue: octokit/types.ts#525
@Jason3S Jason3S mentioned this issue Apr 20, 2023
Merged
Jason3S added a commit to streetsidesoftware/cspell that referenced this issue Apr 20, 2023
@Jason3S
chore: Remove Octokit lock
1ea9640 
Depends upon: octokit/types.ts#525
@Jason3S Jason3S mentioned this issue Apr 20, 2023
Merged
@pragmaticivan
Copy link

I can replicate that.

@jakebailey jakebailey mentioned this issue Apr 20, 2023
Merged
Closed
wolfy1339 added a commit that referenced this issue Apr 21, 2023
@wolfy1339
fix(build): add script to fix package json from build step (#526)
e795680 
Fixes #525
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Apr 21, 2023
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kachick kachick mentioned this issue Apr 22, 2023
Merged
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): add script to fix package json from build step octokit/types.ts
3 participants
@pragmaticivan @wolfy1339 @octokitbot