Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(types): allow non-truthy values in generated output #556

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 13, 2021

WhiteSource Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: "before 5am on monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 13, 2021
Copy link
Member

@wolfy1339 wolfy1339 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a difference between current types in repo and generated types.
While the diff seems valid, it should be investigated further

diff --git a/payload-types/schema.d.ts b/payload-types/schema.d.ts
index 23b107e..ac0d68c 100644
--- a/payload-types/schema.d.ts
+++ b/payload-types/schema.d.ts
@@ -1506,7 +1506,7 @@ export interface GitHubOrg {
   name?: "GitHub";
   email?: null;
   avatar_url: "https://avatars.githubusercontent.com/u/9919?v=4";
-  gravatar_id: string;
+  gravatar_id: "";
   url: "https://api.github.com/users/github";
   html_url: "https://github.com/github";
   followers_url: "https://api.github.com/users/github/followers";
@@ -1519,7 +1519,7 @@ export interface GitHubOrg {
   events_url: "https://api.github.com/users/github/events{/privacy}";
   received_events_url: "https://api.github.com/users/github/received_events";
   type: "Organization";
-  site_admin: boolean;
+  site_admin: false;
 }
 export interface CodeScanningAlertClosedByUserEvent {
   action: "closed_by_user";

@wolfy1339
Copy link
Member

It seems that this is actually a fix in json-schema-to-typescript where they allow non-truthy values: bcherny/json-schema-to-typescript@cf3c40a

@wolfy1339 wolfy1339 changed the title build(deps): lock file maintenance fix(types): allow non-truthy values in generated output Sep 13, 2021
@wolfy1339 wolfy1339 merged commit 1bd545e into master Sep 13, 2021
@wolfy1339 wolfy1339 deleted the renovate/lock-file-maintenance branch September 13, 2021 02:19
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 4.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants