Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: Tag templates #83

Merged
merged 24 commits into from
Jun 2, 2021
Merged

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented May 21, 2021

Contents

New Features

  • Add file tags template to twine schema
  • Add file tags template validation for datasets

Breaking changes

  • Require datasets to be inside "datasets" field in "manifest" fields of twine.json
  • Make tags an object and add labels field to manifest schema
  • Separate old tags in examples and tests into labels and new tags

Minor fixes and improvements

  • Split getting schema from validating against schema in Twine

Quality Checklist

  • New features are fully tested (No matter how much Coverage Karma you have)
  • New features are documented

@cortadocodes cortadocodes self-assigned this May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #83 (9fee567) into release/0.0.20 (3eb5f12) will increase coverage by 1.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/0.0.20      #83      +/-   ##
==================================================
+ Coverage           85.83%   87.05%   +1.22%     
==================================================
  Files                   7        7              
  Lines                 233      255      +22     
==================================================
+ Hits                  200      222      +22     
  Misses                 33       33              
Impacted Files Coverage Δ
twined/exceptions.py 100.00% <100.00%> (ø)
twined/twine.py 81.14% <100.00%> (+2.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb5f12...9fee567. Read the comment docs.

@cortadocodes cortadocodes marked this pull request as ready for review May 21, 2021 11:22
@cortadocodes cortadocodes mentioned this pull request May 21, 2021
11 tasks
@cortadocodes cortadocodes requested a review from thclark May 25, 2021 10:52
@cortadocodes cortadocodes force-pushed the feature/tag-templates-2 branch from 47b0b09 to 0d167dc Compare May 26, 2021 14:24
@cortadocodes cortadocodes merged commit 6d80a61 into release/0.0.20 Jun 2, 2021
@cortadocodes cortadocodes deleted the feature/tag-templates-2 branch June 2, 2021 12:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants