Skip to content

[FIX] selection_input: fix range deletion #5932

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: saas-18.2
Choose a base branch
from
Open

[FIX] selection_input: fix range deletion #5932

wants to merge 1 commit into from

Conversation

Rachico
Copy link
Contributor

@Rachico Rachico commented Mar 17, 2025

Prior to this commit, clicking the trash icon next to a range in DV/CF did not remove the range due to a missing event handler. This bug was introduced by this commit: f64e482

This commit ensures that the deletion action is correctly triggered, allowing a proper management of CF/DV rules

Steps to reproduce:

  • Create a DV/CF rule
  • Add a new range (valid or invalid)
  • Click on the trash icon next to the range
  • Nothing happens

Task: 4589387

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Mar 17, 2025

Pull request status dashboard

@Rachico Rachico mentioned this pull request Mar 17, 2025
Closed
14 tasks
@Rachico Rachico closed this Mar 17, 2025
@Rachico Rachico reopened this Mar 17, 2025
@Rachico
[FIX] selection_input: fix range deletion
0a4ee97 
Prior to this commit, clicking the trash icon next to a range in DV/CF
did not remove the range due to a missing event handler. This bug was
introduced by this commit: f64e482

This commit ensures that the deletion action is correctly triggered,
allowing a proper management of CF/DV rules

Steps to reproduce:
- Create a DV/CF rule
- Add a new range (valid or invalid)
- Click on the trash icon next to the range
- Nothing happens

task:4589387
@Rachico Rachico force-pushed the saas-18.2-remove-ranges-in-dv-mera branch from b456dd1 to 0a4ee97 Compare March 17, 2025 10:20
@Rachico Rachico changed the title [FIX] data_validation,conditional_format: fix rule range deletion [FIX] selection_input: fix range deletion Mar 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rachico @robodoo