[FIX] autofill: smaller revisions #6056
Closed
+108
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
When auto-filling cell, the UPDATE_CELL commands always contains all 3 properties: content, style and format. They could be useless though. Typically, when you autofill on blank cells, it useless to have `style: null` and `format: ""` in the command. Auto-fill A1 to Z1, then the row A1:Z1 to A100:Z100 before: 275kB after: 210kB (~25% smaller)
LucasLefevre
force-pushed
the
18.0-smaller-autofill-revisions-lul
branch
from
f7f3617 to
adaf899
Compare
|
nope: #6128 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When auto-filling cell, the UPDATE_CELL commands always contains all 3 properties: content, style and format.
They could be useless though. Typically, when you autofill on blank cells, it useless to have
style: nullandformat: ""in the command.Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist