-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[ADD] estate: Added Estate App #779
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: 18.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything's ok code wise!
Just your commit titles don't follow the guidelines. They should have a specific title specifying a tag and the module concerned by the change. In this case it's always estate
but it's so you know.
And consider checking the style errors raised by the runbot to fix them.
a02dd52
to
ac536e7
Compare
…from property view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just three small comments, everything is fine to me 👍
No description provided.