Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement minor fixes for SPI encoders #661

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Conversation

Wetmelon
Copy link
Collaborator

@Wetmelon Wetmelon commented Feb 4, 2022

  • Increase SPI clock speed to avoid timing issues
  • Increase SPI encoder error threshold to 5%
  • Reduce SPI signal slew rates to MEDIUM

See https://discourse.odriverobotics.com/t/clarification-on-spi-encoders/6451/61

@Wetmelon Wetmelon requested a review from samuelsadok February 4, 2022 00:23
@samuelsadok samuelsadok merged commit a90ee65 into devel Feb 4, 2022
@samuelsadok samuelsadok deleted the feature/spi_fixes branch February 4, 2022 09:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants