Add vdi profiles implementation #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The temperature limit is connected to the efficiency status of the house.
Co-authored-by: Joris Zimmermann <joris.zimmermann@siz-energieplus.de>
While this is not guaranteed to work, other parts of the code currently work fine if the house names are e.g. integers.
Set heat demand on all summer days to zero. This is not part of VDI 4655
House types other than 'EFH' and 'MFH' cannot be properly tested, because the code would fail before these lines.
Also add new test dependencie 'geopandas' to pyproject.toml
Also update the index files accordingly
jnettels
changed the title
|
In #74 we discussed having tests as classes or just functions. For this PR I have prepared them as classes (just like all the other tests). If desired, I can change them all to plain functions. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #50, @uvchik used my work in https://github.com/jnettels/lpagg as a basis to create a much more performant implementation of the VDI4655 load profiles. I have used his work ever since and I am very grateful for it.
While his PR was basically feature-complete, it was lacking some polish, tests and documentation, and has been stale for several years.
I now found the time to take it on myself to carry his work across the finish line. But his branch had many conflicts in unrelated files with dev, which made merging a pain. To get a clean history while retaining authorship, I cherry-picked all relevant commits from his branch and created a new branch for this PR, adding my contributions:
Closes #36
I hope this can be merged now, because I still think it is a nice addition to demandlib.
A side-note unrelated to this PR:
https://github.com/jnettels/lpagg has been evolving, too. My "load profile aggregator" can now use demandlib as
the (preferred) source. Since all profile generators in demandlib use their own interface, lpagg attempts to streamline the profile generation for datasets of mixed building types into one workflow. Especially the documentation is still lacking, but maybe it is of
interest for someone out there.