Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(gen): do not set span status for 4xx responses #1354

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Dec 2, 2024

Fixes #1351

@tdakkota tdakkota requested a review from ernado December 2, 2024 13:00
@tdakkota tdakkota marked this pull request as ready for review December 2, 2024 13:00
@tdakkota tdakkota enabled auto-merge December 2, 2024 13:00
@tdakkota tdakkota merged commit 64b8881 into ogen-go:main Dec 2, 2024
14 checks passed
@tdakkota tdakkota deleted the fix/otel-status-code branch December 3, 2024 00:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: do not set error on 4xx codes
2 participants