-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WebGL map vs simpler canvas #192
Comments
Out of curiosity, which device/browser isn't supported? "Mapbox GL JS is supported in all modern browsers." https://www.mapbox.com/help/mapbox-browser-support/ Unfortunately, I'm not aware of a non-GL implementation that would be compatible with the Mapbox GL API, so such a fallback would mean duplication or rewrite of the current map code. Link to an external site (umap.openstreetmap.fr?) that can display the GeoJSON data might be more feasible. In any case, it would be nice to have the GeoJSON conversion as a REST API (running on Heroku or similar). I'm pretty sure the data is meant to be open data :-) Regarding fallbacks, do we need a table representation of the events for visually impaired users? |
@millette is it Chromium not rendering correctly? I'll check the fallback option. I can upload the CSVs of past years and the current one if that's useful for you. Otherwise, you can definitely use the geojson, it's CC-by. |
@tuuka it will depend on the hardware used. Why demand GL at all? @tlacoyodefrijol Chromium works but it's slow (no 3d acceleration here). What geojson? The only dataset I found was by looking at the network queries made when loading opendataday.org. If you say the events data is open (can I have that in writing, please? ;-) then I can let loose and turn coordinates to city/country names and put that in a table too - but it's a whole other story. |
@millette we convert the data from a CSV to geojson. Let me confirm the database license so you can let loose. |
You saw my script above, right? I just had to update it to fix a few coords errors (null values). You can see it rendered here too: |
Created an "open data" issue #195 |
Using data from https://caniuse.com/ I made this simple map of African countries and their most popular browser: I don't think WebGL is well supported in those countries, which are a large part of the OpenDataDay effort. My "plain" map: http://jido2018.waglo.com/#mapid |
I'm not able to see the map on https://opendataday.org/ since my browser doesn't support it.
Could you add a leaflet fallback, such as https://github.com/millette/jido2018/blob/master/jido2018.json ?
I wrote a small script to convert your spreadsheet to a geojson file:
https://github.com/millette/jido2018/tree/master/scripts
In any case, is it ok for me to share this geojson file and rendered map? I will always mention where the official map can be found (if not seen ;-)
The text was updated successfully, but these errors were encountered: