Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update french translation #290

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Update french translation #290

merged 3 commits into from
Jan 28, 2021

Conversation

pyrog
Copy link

@pyrog pyrog commented Jan 28, 2021

Close #287 and #288


Please preserve this line to notify @lwinfree

@pyrog pyrog changed the title Menu and footer FR translation Update french translation Jan 28, 2021
Copy link
Contributor

@lwinfree lwinfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pyrog! Thanks for this PR. Overall it looks good, but there are a few things I suggest changing:

  • line 9: remove the space before !
  • line 15: remove the space before ?
  • line 29: the emphasis (the asterisks) should be on the word environnementales
  • line 41: remove the spaces before the punctuation
  • line 47: please use Individus instead of citoyen. People do not have to be citizens to participate
  • line 155: seems to have some character rendering issues  
  • line 160: remove the space before :

Thanks!

@pyrog
Copy link
Author

pyrog commented Jan 28, 2021

line 9, 15, 41, 160

In french the space is mandatory before :, ? and ! 😉

line 155: seems to have some character rendering issues  

I run the Lecktor locally an the pages are generated without issue and displayed correctly.
(tested with Chrome, Firefox and Safari)

Non breaking space

line 29: the emphasis (the asterisks) should be on the word environnementales

Ok, it's better and the page layout is not broken.

Données environnementales

Note: It is on data in the english version:
Environmental data

line 47: please use Individus instead of citoyen. People do not have to be citizens to participate

I use citoyen because it sound better in french (mean people involved in the "city").
'individu' is connoted (used by the police to describe offender)
citoyen in french don't mean people with i.e. the nationality of the country, but people living in the country.

Move emphasis on environmental word
@lwinfree
Copy link
Contributor

@pyrog I've learned something new today! No worries about using "citoyen" - it sounds like it doesn't have the same connotation as it does in English.

@lwinfree lwinfree requested review from lwinfree and removed request for lwinfree January 28, 2021 21:53
@lwinfree lwinfree merged commit eb72a6e into okfn:master Jan 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken page layout in French
2 participants