Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make build in CI for Mac 13, not for latest #578

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Make build in CI for Mac 13, not for latest #578

merged 3 commits into from
Oct 7, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Oct 4, 2024

It has been reported that the built version is not running in older versions of Mac. I have created this PR to target version 13 in mac for the generated build in CI to see if this solves the issue.


@roll we have created this PR to address the issue that the app is not installing in mac versions 14+, I have made a build for mac-13 that has been tested in mac-13 and mac-14 and installs the app successfully. (Tested by @Faithkenny and @romicolman manually).

The possible explanation can be found on this thread:

https://forums.developer.apple.com/forums/thread/739988
Right. macOS 14 introduced a new container data protection feature. To learn more about that, see the link in Trusted Execution Resources.The solution here is to sign your code with a stable signing identity. For day-to-day development, that should be your Apple Development signing identity. Do this locally and on your CI system. 

I would suggest that we target macos-13 for now as our build version until we solve the certificate issue. And anyway targetting the latest version is not the best idea, we need to target older versions as well.

@guergana guergana changed the title Make build in CI for Mac 14, not for latest Make build in CI for Mac 13, not for latest Oct 4, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 305e36d
Status: ✅  Deploy successful!
Preview URL: https://dc3e8ebb.opendataeditor.pages.dev
Branch Preview URL: https://build-for-mac-14.opendataeditor.pages.dev

View logs

@guergana guergana marked this pull request as draft October 4, 2024 16:09
@guergana guergana requested a review from roll October 4, 2024 17:19
@guergana guergana marked this pull request as ready for review October 4, 2024 17:19
Copy link
Collaborator

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it!

@roll roll merged commit 9ca28da into main Oct 7, 2024
9 checks passed
@roll roll deleted the build-for-mac-14 branch October 7, 2024 10:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants