Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix releasing flow #584

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Fix releasing flow #584

merged 3 commits into from
Oct 15, 2024

Conversation

roll
Copy link
Collaborator

@roll roll commented Oct 8, 2024


Fixed releasing workflow that eliminates the error-prone manual step is here - https://577-improve-release-flow.opendataeditor.pages.dev/contributing/development/#releasing

I still don't like that this process includes an extra PR/review for a version change in package.json but it doesn't seem to be other options that works well with electron-builder publish command.

@roll roll requested a review from guergana October 8, 2024 12:13
Copy link

cloudflare-workers-and-pages bot commented Oct 8, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: c99ed30
Status: ✅  Deploy successful!
Preview URL: https://2e2efef3.opendataeditor.pages.dev
Branch Preview URL: https://577-improve-release-flow.opendataeditor.pages.dev

View logs

package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@roll roll merged commit f6f396d into main Oct 15, 2024
9 checks passed
@roll roll deleted the 577/improve-release-flow branch October 15, 2024 08:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release on the vX.Y.Z PR merged instead of local make release
2 participants