Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Ionic 4 Support #20

Merged
merged 17 commits into from
Apr 28, 2019
Merged

Add Ionic 4 Support #20

merged 17 commits into from
Apr 28, 2019

Conversation

fleboulch
Copy link
Contributor

Fix #19
Fix jhipster/generator-jhipster-ionic#67
Fix jhipster/generator-jhipster-ionic#58
Fix #18

Auth supported

  • JWT
  • OAuth

App tested

  • Monolith
  • Microservices

Left TODO

  • Replace baseref in ionic.starter.json with latest hash commit
  • Add editorconfig
  • Add entity support (will be added once this starter is available on the ionic-team repo)
  • Update README.md
  • Fix CI?

@mraible mraible changed the title Ionic4 Add Ionic 4 Support Apr 28, 2019
@mraible mraible merged commit a74f817 into oktadev:master Apr 28, 2019
@fleboulch fleboulch deleted the ionic4 branch April 28, 2019 19:40
@senakas
Copy link

senakas commented May 3, 2019

Hi,
I tried to generate ionic 4 app to integrate jhipster (" ionic start ionic4testi oktadeveloper/jhipster").
But I got the following error.
Unable to find starter template for oktadeveloper/jhipster

Could you please advise me.

Regards
Senaka

@fleboulch
Copy link
Contributor Author

fleboulch commented May 3, 2019

Yes, you got this error because my PR in the ionic-teams repository (ionic-team/starters#749) has not been merged.
So the code in this repo isn't available at this time.

The CI is failing and I have to fix it to merge the PR in their repo.

By the way, I can provide you a workaround if you want this code right now

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants