Skip to content

Commit

Permalink
PR feedback - revert testApp/Main and add focus handling
Browse files Browse the repository at this point in the history
  • Loading branch information
oldtinroof committed Feb 1, 2021
1 parent 21d42dd commit 7240ea8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
4 changes: 2 additions & 2 deletions example/private-routes-async/src/App.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
<p>That's what it's all about!</p>
</Route>

<PrivateRoute path="profile" let:location>
<h3>Welcome {$user.username}</h3>
<PrivateRoute path="profile" let:location let:registerFocus>
<h3 use:registerFocus>Welcome {$user.username}</h3>
<button on:click={handleLogout}>Logout</button>
</PrivateRoute>
</main>
Expand Down
17 changes: 9 additions & 8 deletions test/testApp/src/Main.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"data-has-attr": true,
"data-duplicate-attr": "getProps",
})}
to="about">GET PROPS</Link
to="about"
>GET PROPS</Link
>
<Link data-testid="link-about-rel" to="about">ABOUT REL</Link>
<Link data-testid="link-about-abs" to="/about">ABOUT ABS</Link>
Expand All @@ -45,7 +46,8 @@
<Link
data-testid="link-about-push-state"
to="about"
state={{ value: "test-push-state" }}>ABOUT PUSH STATE</Link
state={{ value: "test-push-state" }}
>ABOUT PUSH STATE</Link
>
<Link data-testid="link-about-replace" to="about" replace>
ABOUT REPLACE
Expand All @@ -54,7 +56,8 @@
data-testid="link-about-replace-state"
to="about"
state={{ value: "test-replace-state" }}
replace>ABOUT REPLACE STATE</Link
replace
>ABOUT REPLACE STATE</Link
>
<Link data-testid="link-blog" to="blog">BLOG</Link>
<Link data-testid="link-blog-match-empty" to="blog/match">MATCH EMPTY</Link>
Expand All @@ -63,7 +66,8 @@
</Link>
<Link
data-testid="link-blog-match-to-splat"
to="blog/match/some-path/some-splat">MATCH SOME PATH AND SPLAT</Link
to="blog/match/some-path/some-splat"
>MATCH SOME PATH AND SPLAT</Link
>

<div use:links>
Expand Down Expand Up @@ -96,10 +100,7 @@
<a
use:link={customNavigate}
data-testid="action-link-custom-navigate"
href="/about"
>
ACTION LINK ABOUT CUSTOM NAVIGATE
</a>
href="/about"> ACTION LINK ABOUT CUSTOM NAVIGATE </a>
</nav>
<br />
<main>
Expand Down

0 comments on commit 7240ea8

Please # to comment.