Cleanup routine throws ArgumentException

[naspert]

Calling Process.GetProcessById throws if the process with the given id is not running.
cf.
https://github.com/oleg-shilo/cs-script/blob/master/Source/Utils.cs#L288

wrapping the call inside a try/catch block should do the trick...

[naspert]

(cf. official doc https://msdn.microsoft.com/en-us/library/76fkb36k(v=vs.110).aspx )

[oleg-shilo]

Not sure I follow you. It is already wrapped. I the very same source code link you provided::

try
{
    if (Process.GetProcessById(pid) != null)
        continue; //still running
}
catch
{
    //GetProcessById will throw if pid is not running and Utils.FileDelete handles all unexpected
}

[naspert]

true I missed that. However this behavior has changed wrt previous versions, increasing the noise level when debugging. If I set the environment var "CSScript_Suspend_Housekeeping" I should avoid entirely this routine, right ? (currently tracing an issue at when my application exits and CSScript exceptions get in the way...)

[naspert]

(replying to myself) with the env. variable properly set, I managed to trace the real problem. I will close the issue (but still a non-throwing version would be a nice feature ;)

[oleg-shilo]

Well... I agree. I also found it extremely annoying when I have to step over handled exceptions while hunting for a real ones.
I didn't want to replace it with the all process lookup by id unless there is a good reason for this. But since you raised this issue I will do the replacement.

[naspert]

I guess you can replace this call by something like this (which should not throw)
var tmp = Process.GetProcesses().Select(p => p.Id);
...
and
if (tmp.Contains(pid)) continue;

[oleg-shilo]

Of course. It is exactly what I am going to do. Another good candidate is this:

if (Process.GetProcesses().Any(p => p.Id == pid))
    continue; //still running

Another reason for not doing it earlier is that .NET 1.1 didn't have LINQ and foreach... really hurts my eyes. :) Yes, yes I know, foreach is the fastest option but it.... just kills the fun. :)

But now support for 1.1 is over so many things are becoming much simpler.

[oleg-shilo]

Fixed in 58ce13f
Planned for v3.21 release

[oleg-shilo]

Fixed in Release v3.21.1