Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Autofill ballot ID to currently open election? #18

Closed
rye opened this issue Mar 3, 2018 · 1 comment
Closed

Autofill ballot ID to currently open election? #18

rye opened this issue Mar 3, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rye
Copy link
Contributor

rye commented Mar 3, 2018

In 30ef630 I add an error if you attempt to access /ballots/new without any election_id param being passed. (either as a JSON body or as a URL query string parameter, Rails doesn't care.)

I wasn't sure if this was optimal. We could autofill the ballot ID to the current election… @erichkauffman, thoughts? Since the case where someone isn't logged in is already handled at the start of this handler, it seems like this makes sense.

rye added a commit that referenced this issue Mar 3, 2018
This might need to be refactored later.

[GitHub] See #18 for more.
@rye rye self-assigned this Mar 3, 2018
@erichkauffman
Copy link

Autofilling the ballot ID seems fine since I don't anticipate we will be having multiple elections at the same time.

@rye rye added this to the Version 1 milestone Mar 3, 2018
@rye rye added the enhancement New feature or request label Mar 4, 2018
@rye rye assigned rye and unassigned rye Mar 4, 2018
@rye rye closed this as completed in #32 Mar 5, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants