This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With "verify=False" set, urllib3 would log every call as:
That's pretty verbose.
Kubernetes normally puts the ca.crt file in with the service token, so we can use that to verify TLS requests and stop the logging.
Added a
K8S_CA_CERT_PATH
environment variable, which defaults to the K8s ca.crt file. This "just works" on my install.Also added a "--insecure-tls" option to restore the former behavior for local testing or anywhere that the CA isn't available.
I updated the README with this behavior.
Minor:
Changed
total
retries to 3 to matchconnect
, as TLS negotiation failures don't count asconnect
errors, and the default timeout was reaching minutes.Sorted imports and added
getopt
for the--insecure-tls
option.