Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace logrus with zap logger #51

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Replace logrus with zap logger #51

merged 3 commits into from
Oct 2, 2024

Conversation

gab-arrobo
Copy link
Contributor

The following was done for this PR:

  1. Replace logrus with zap logger
  2. Test changes with OnRamp using the replace directive in the amf image/pod
  3. Cleanup fmt and log used as logs and in some cases, replace them with the logger
  4. Create release

@gab-arrobo
Replace logrus with zap logger
c6f51b5 
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo requested a review from thakurajayL October 1, 2024 20:41
@gab-arrobo
Remove unused file
22b6c24 
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo marked this pull request as draft October 1, 2024 22:18
@gab-arrobo
Update util version
6152807 
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo marked this pull request as ready for review October 1, 2024 22:32
@gab-arrobo gab-arrobo merged commit 77a9a4c into omec-project:master Oct 2, 2024
7 checks passed
@gab-arrobo gab-arrobo deleted the zap-logger branch October 2, 2024 23:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thakurajayL thakurajayL thakurajayL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gab-arrobo @thakurajayL