This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
chore: Enable fieldalignment go vet check #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
gab-arrobo
reviewed
Jan 27, 2024
pfcpType/PacketRate.go
Outdated
| @@ -26,8 +26,8 @@ type PacketRate struct { | |||
| ULPR bool | |||
There was a problem hiding this comment.
I was expecting these two bool variables to be moved to the end... What do you think?
There was a problem hiding this comment.
Same as the other comments. No error shown by go ve.
PacketRateTimeUnit is a uint8 so we get 4 bytes next to 2 bytes + 2 bytes. I think that would be well accomadated
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
gab-arrobo
approved these changes
Jan 30, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable fieldalignment go vet check in CI
fieldalignment defines an Analyzer that detects structs that would use less memory if their fields were sorted.