Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DMN14-190/DMN14-191/DMN14-192/DMN14-193/DMN14-194/DMN14-195 Changes to the diagrams for conditional, filter and iterator boxed expression #17

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

SimonRinguette
Copy link
Contributor

@SimonRinguette SimonRinguette commented Oct 6, 2021

Related to XSD changes #14, #15 & #16
MM change #18

…o the diagrams for conditional, filter and iterator boxed expressions
@falko
Copy link
Contributor

falko commented Nov 8, 2021

Approved in Ballot 5

@falko falko merged commit 2e9c286 into omg-dmn-taskforce:master Nov 8, 2021
@falko
Copy link
Contributor

falko commented Apr 13, 2022

@SimonRinguette after discusing and reviewing DMN14-195 with Michelle, I noticed that the proposal text also mentioned adding the following to Figure 10.17 Expression class diagram:

Add the following abstract class extending Expression

Iterator
+iteratorVariable: String

Add the following class extending Iterator

For

Add the following abstract class extending Iterator

Quantified

Add the following class extending Quantified

Every

Add the following class extending Quantified

Some

Add the following class

ChildExpression
+id: ID [0..1]

Add the following class extending ChildExpression

TypedChildExpression
+typeRef: String [0..1]

Create one aggregation between ChildExpression and
Expression named value with a cardinality of 1.

Create an aggregation between Iterator and the new
TypedChildExpression class named “in” with a cardinality
of 1.

Create an aggregation between For and ChildExpression
named return with a cardinality of 1.

Create an aggregation between Quantified and
ChildExpression named satisfies with a cardinality of
1.

However the only addition to the diagram seems to be the class Iterator:

Am I missing something or should I raise this as an issue to complete the diagram in DMN 1.5?

@falko
Copy link
Contributor

falko commented Apr 20, 2022

@sringuette any feedback regarding this?

@SimonRinguette
Copy link
Contributor Author

In the metamodel, (magic draw) i've created an ExpressionL4 diagram with these details:

image

However, when doing the actual change, these details were not appropriate for the L3 diagram and would not fit on the real estate we had.

If we want these details in the diagram, you can raise an issue to have that diagram integrated in 1.5

@falko
Copy link
Contributor

falko commented Apr 26, 2022

We discussed it in today's RTF meeting and are going to raise an issue to add the diagram in DMN 1.5 as you suggested.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants