Pass options by reference so the changes persist #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @robdrimmie, thanks for the catch. TBH that function setArgument() seems like some unnecessary refactoring. Not sure why it's still around. Feel free to rip it out if you want! |
|
@omniphx can you build a release for this? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny change that resolves a problem I encountered today. Please let me know if I'm completely misguided. I don't have a quick example scenario setup but I can if that would be helpful.
By passing
$optionsby value, the options weren't being set elsewhere in the application, so for example POSTing to create a new instance of a sObject would fail because the request would be sent as a GET request. Passing the options array by reference (which appears to be the case in earlier versions of this function) resolved my difficulties immediately.