Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

select() ignores throw_on_missing for ListConfig #563

Closed
odelalleau opened this issue Feb 24, 2021 · 0 comments · Fixed by #564
Closed

select() ignores throw_on_missing for ListConfig #563

odelalleau opened this issue Feb 24, 2021 · 0 comments · Fixed by #564
Assignees
@odelalleau
Labels
bug Something isn't working
Milestone
OmegaConf 2.1

Comments

@odelalleau
Copy link
Collaborator

Describe the bug
The following code should raise an exception, but does not:

cfg = OmegaConf.create(["???"])
OmegaConf.select(cfg, key, default=0, throw_on_missing=True)
@odelalleau odelalleau added the bug Something isn't working label Feb 24, 2021
@odelalleau odelalleau self-assigned this Feb 24, 2021
odelalleau added a commit to odelalleau/omegaconf that referenced this issue Feb 24, 2021
@odelalleau
Fix handling of throw_on_missing flag for select() on ListConfig
3380d7f 
Fixes omry#563
@odelalleau odelalleau mentioned this issue Feb 24, 2021
Merged
odelalleau added a commit to odelalleau/omegaconf that referenced this issue Feb 24, 2021
@odelalleau
Fix handling of throw_on_missing flag for select() on ListConfig
cc90bb3 
Fixes omry#563
@omry omry added this to the OmegaConf 2.1 milestone Feb 24, 2021
@omry omry closed this as completed in #564 Feb 24, 2021
odelalleau added a commit to odelalleau/omegaconf that referenced this issue Mar 10, 2021
@odelalleau
Fix handling of throw_on_missing flag for select() on ListConfig
313d9fa 
Fixes omry#563
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@odelalleau odelalleau

Labels
bug Something isn't working
Projects
None yet
Milestone
OmegaConf 2.1
Development

Successfully merging a pull request may close this issue.

Fix handling of throw_on_missing flag for select() on ListConfig odelalleau/omegaconf
2 participants
@omry @odelalleau