Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove OmegaConf 2.0 deprecated APIs #671

Closed
omry opened this issue Apr 8, 2021 · 2 comments · Fixed by #672
Closed

Remove OmegaConf 2.0 deprecated APIs #671

omry opened this issue Apr 8, 2021 · 2 comments · Fixed by #672
Milestone

Comments

@omry
Copy link
Owner

omry commented Apr 8, 2021

BaseContainer.{pretty,select,update_node} have all been deprecated in OmegaConf 2.0 and should no longer be used.

@titu1994
Copy link

titu1994 commented Jun 7, 2021

Hi Omry - just a note. According to Semver - https://semver.org/#how-should-i-handle-deprecating-functionality, OmegaConf 2.1 should not have dropped this, but the next major version (say 3.0) should have dropped it.

While these are semantic rules (by definition) and are not enforced explicitly - it helps keep maintain compatibility with dependent downstream libraries.

@omry
Copy link
Owner Author

omry commented Jun 7, 2021

semver is a recommendation and not something all projects in the world follows.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants