Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove deprecated BaseContainer.{pretty,select,update_node} #672

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Remove deprecated BaseContainer.{pretty,select,update_node} #672

merged 1 commit into from
Apr 8, 2021

Conversation

omry
Copy link
Owner

@omry omry commented Apr 8, 2021 •
edited
Loading

Closes #671

@omry omry requested review from odelalleau and Jasha10 April 8, 2021 00:34
Jasha10
Jasha10 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@omry omry merged commit 7261101 into master Apr 8, 2021
@omry omry deleted the remove-deprecated branch April 8, 2021 00:42
odelalleau
odelalleau reviewed Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@odelalleau odelalleau odelalleau left review comments

@Jasha10 Jasha10 Jasha10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove OmegaConf 2.0 deprecated APIs
3 participants
@omry @odelalleau @Jasha10