Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modify .coveragerc to fix CI coverage #1204

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Modify .coveragerc to fix CI coverage #1204

merged 1 commit into from
Jan 5, 2025

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Jan 5, 2025

Motivation

code coverage CI is failing.
This PR attempts to fix that.

It seems there were two problems with the .coveragerc file:

  • when running coverage report, the run.omit setting in .coveragerc was not being picked up. I moved the contents of run.omit to report.omit.
  • The omission pattern *tests* was not excluding the tests folder form coverage. I changed *tests* to `/tests/``.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Verify coverage now succeeds on CI, and that coverage is still measured for the desired omegaconf source directory.

@Jasha10 Jasha10 merged commit d61b588 into master Jan 5, 2025
7 checks passed
@Jasha10 Jasha10 deleted the fix-ci-coverage branch January 5, 2025 19:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant