-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add support for custom sized root block devices. #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the tiny documentation update, would it be possible to add a small test to cover this functionality?
action.yml
Outdated
@@ -16,6 +16,9 @@ inputs: | |||
aws_image_id: | |||
description: "The machine AMI to use for your runner. This AMI can be a default but should have docker installed in the AMI. Will not start if not specified." | |||
required: false | |||
aws_root_device_size: | |||
description: "The root device size in GB to use for your runner. Optional" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add: "If not given, defaults to ?? GB" (fill in correct value for ??
-- is that 30
? can't remember)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dependent on the AMI. If you don't provide us with one, we default to the AMI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can improve the docs to reflect that though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. Probably good to point that out, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is 30 for most images, but the Deep Learning ones use 75 GB root devices.
Ah, missed the mention of testing in the PR message (jumped straight to the code). Just add the docs improvement and this should be good to go. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 95.20% 90.78% -4.43%
==========================================
Files 3 3
Lines 334 358 +24
==========================================
+ Hits 318 325 +7
- Misses 16 33 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This adds new support for new custom root devices when provisioning AWS instances. It adds the ability to read and modify the existing block devices for the AMI, however this requires adding the
ec2:DescribeImages
permission. This change will not work if you do not edit the permissions of the IAM policy to be aligned with this:Unit testing is not written for this but a brief integration test can be found using this branch here: https://github.com/omsf-eco-infra/openmm-gpu-test/actions/runs/12698008379. I think proper testing can be added for this when we migrate to
start-aws-gha-runner
, since most of this testing is about argument validation.