Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merge dev #21

Merged
merged 8 commits into from
May 11, 2022
Merged

Merge dev #21

merged 8 commits into from
May 11, 2022

Conversation

knakamura13
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
omshub-storybook ✅ Ready (Inspect) Visit Preview May 11, 2022 at 6:43AM (UTC)
website ✅ Ready (Inspect) Visit Preview May 11, 2022 at 6:43AM (UTC)

@knakamura13
Copy link
Contributor Author

Commit 4d48ff5 should be titled "docs: add commit instructions to readme" but was mistakenly given the same commit message as a prior commit.

Copy link
Contributor

@driscoll42 driscoll42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me so much as the readme, but I can't comment on the other files. I trust it works though.

Copy link
Contributor

@tran-christian tran-christian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I double checked that the commit lint was working too!

@vercel vercel bot temporarily deployed to Preview – website May 11, 2022 05:59 Inactive
@vercel vercel bot temporarily deployed to Production – omshub-storybook May 11, 2022 05:59 Inactive
@vercel vercel bot temporarily deployed to Preview – website May 11, 2022 06:33 Inactive
@vercel vercel bot temporarily deployed to Production – omshub-storybook May 11, 2022 06:34 Inactive
@vercel vercel bot temporarily deployed to Preview – website May 11, 2022 06:36 Inactive
@vercel vercel bot temporarily deployed to Preview – website May 11, 2022 06:43 Inactive
@vercel vercel bot temporarily deployed to Production – omshub-storybook May 11, 2022 06:43 Inactive
@tran-christian tran-christian merged commit 3e456a8 into main May 11, 2022
@vercel vercel bot temporarily deployed to Preview – omshub-storybook May 11, 2022 12:37 Inactive
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants