Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FI-1638: SMART v2 #177

Merged
merged 13 commits into from
Aug 9, 2022
Merged

FI-1638: SMART v2 #177

merged 13 commits into from
Aug 9, 2022

Conversation

Jammjammjamm
Copy link
Contributor

@Jammjammjamm Jammjammjamm commented Jul 22, 2022 •
edited
Loading

Initial SMART v2 integration.

This branch requires:

You can test things out by checking out this branch, making sure the smart test kit is up to date, and running the svap-testing branch in core.

@Jammjammjamm Jammjammjamm self-assigned this Jul 22, 2022
@Jammjammjamm Jammjammjamm changed the title WIP: Fi-1638: SMART v2 WIP: FI-1638: SMART v2 Jul 22, 2022
@Jammjammjamm Jammjammjamm changed the title WIP: FI-1638: SMART v2 FI-1638: SMART v2 Jul 26, 2022
@Jammjammjamm Jammjammjamm marked this pull request as ready for review July 26, 2022 13:04
@Jammjammjamm Jammjammjamm requested review from arscan and radamson July 26, 2022 13:56
radamson
radamson reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@radamson radamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PKCE options appears to be unlocked for the standalone and EHR groups, but locked in limited app and public launch even though the config would suggest otherwise.

lib/onc_certification_g10_test_kit/smart_standalone_patient_app_group.rb Outdated Show resolved Hide resolved
lib/onc_certification_g10_test_kit/smart_ehr_practitioner_app_group.rb Show resolved Hide resolved
lib/onc_certification_g10_test_kit/smart_standalone_patient_app_group.rb Show resolved Hide resolved
@Jammjammjamm Jammjammjamm merged commit 34988ed into main Aug 9, 2022
@Jammjammjamm Jammjammjamm deleted the fi-1638-smart-v2 branch August 9, 2022 16:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@radamson radamson radamson approved these changes

@arscan arscan Awaiting requested review from arscan

Assignees

@Jammjammjamm Jammjammjamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jammjammjamm @radamson