Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: include checks if virtual mod is not enabled #60

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

petrovska-petro
Copy link
Collaborator

closes #56

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (2572cea) to head (2b661e9).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feat/test-fresh-safe      #60      +/-   ##
========================================================
+ Coverage                 89.05%   89.16%   +0.10%     
========================================================
  Files                         3        3              
  Lines                       201      203       +2     
  Branches                     21       23       +2     
========================================================
+ Hits                        179      181       +2     
  Misses                       21       21              
  Partials                      1        1              
Files Coverage Δ
src/RoboSaverVirtualModule.sol 88.13% <100.00%> (+0.20%) ⬆️

Base automatically changed from feat/test-fresh-safe to main June 18, 2024 11:46
Copy link
Contributor

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean, good coverage

@petrovska-petro petrovska-petro merged commit a9dcb68 into main Jun 19, 2024
2 checks passed
@petrovska-petro petrovska-petro deleted the feat/check-module-enabled branch June 19, 2024 11:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: ensure that it checks that the virtual module is actually enabled
2 participants