-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: basic flow content #14
Conversation
getting these warnings when compiling, maybe these could be tackled once we are ready to implement our own
|
i think is simply the compiler highligthing that in that method there is not manipulation of the blockchain state, so we could feel safe labelling them as 'pure', no? |
|
…ore-upgradeable-contracts-part-1` guidance for proxied safe
…in the exec logic of `executeFromPlugin`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test passes!!!!!
some future steps i can think of:
- move
relayer
to the manager/registry (possibly an array of relayers) - split
executeFromPlugin
into a queue and execute function? - rename
DummyModule
toHarvesterPlugin
, since it now has a clear role it fulfills
forge test -vvv