feat: ui skeleton, deployment scripts and addr of dummy factory on goerli-optimism #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ | |||
| "scripts": { | |||
| "anvil": "source .env && anvil --fork-url $ANVIL_FORK_URL --chain-id $ANVIL_CHAIN_ID", | |||
| "deploy": "source .env && forge create contracts/src/ModuleFactory.sol:ModuleFactory --rpc-url $FORGE_RPC_URL --private-key $FORGE_PRIVATE_KEY --etherscan-api-key $ETHERSCAN_API_KEY --verify", | |||
| "deploy:module": "source .env && forge create contracts/src/modules/DummyModule.sol:DummyModule --constructor-args 0x99999315a1AE71633E95fB35601B59180eC8D61d 604800 --rpc-url $FORGE_RPC_URL --private-key $FORGE_PRIVATE_KEY --etherscan-api-key $ETHERSCAN_API_KEY --verify", | |||
There was a problem hiding this comment.
would suggest not giving the singleton module actual address or cadence values
There was a problem hiding this comment.
added that cmd to have one deployed to allow all the one that we get deployed to be auto-verified, the args does not affect that process
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goerli Opti dummy factory addr is plugged here
Test:
npm run devSample of txs thru ui: