Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: allow in ui to update config values #7

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

petrovska-petro
Copy link
Collaborator

No description provided.

@gosuto-inzasheru
Copy link
Contributor

ah interesting.

so in the fleek preview no tx is popping up for me when clicking update.

however, when running locally, the dapp recognises i dont have the setter module deployed yet and it actually says none deployed (expected behaviour)

so why would the fleek version not recognise that i am on an old module version still? 🤔

Copy link
Contributor

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected, was able to deploy module and adjust cadence afterwards: https://goerli-optimism.etherscan.io/tx/0xefd52069ae2ff9e0d907d93eccae5863b4ee32763e09d28631dc7424b6a07cb9#eventlog

@gosuto-inzasheru
Copy link
Contributor

ah shit i should not have been the one to merge main:

Review required
New changes require approval from someone other than gosuto-inzasheru because they were the last pusher.

@gosuto-inzasheru
Copy link
Contributor

bypassing branch protections

@gosuto-inzasheru gosuto-inzasheru merged commit 6bd0784 into main Aug 8, 2023
@gosuto-inzasheru gosuto-inzasheru deleted the feat/allow-update-module-config branch August 8, 2023 11:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants