Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make World Debugger usable in non-VRChat projects #27

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Conversation

hai-vr
Copy link
Contributor

@hai-vr hai-vr commented Feb 15, 2024

  • Generic project types now run the World debugger.
  • Code paths that depend on VRChat are muted if SDK3 is not found.
  • Remove VPM dependency to VRChat:
    • VRWorldToolkit does not need the VRChat SDK to be used.

Copy link
Owner

@oneVR oneVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I'd want to remove the VRCSDK2 references since I don't really want to provide explicit support for it anymore and the older Unity versions likely wouldn't work with the latest changes to begin with. If things are still working currently once I've finished slowly updating things to use UIToolkit that would likely be what breaks it.

- Generic project types now run the World debugger.
- Code paths that depend on VRChat are muted if SDK3 is not found.
- VRWorldToolkit does not need the VRChat SDK to be used.
@@ -10,7 +10,6 @@
"com.unity.postprocessing": "3.1.1"
},
"vpmDependencies": {
"com.vrchat.base" : "^3.2.x"
Copy link
Owner

@oneVR oneVR Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a situation where I want to define a more specific version of the SDK in the future if there are bigger changes to features that are touched by the toolkit, but I don't think it's important enough right now that it needs to be addressed before merging this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, optional dependency is in a kind of tough spot.
In my use case, I want to import VRWorldToolkit in a OSC+SteamVR Overlay project and other VCC dependencies that don't depend on the VRChat SDK.

@hai-vr
Copy link
Contributor Author

hai-vr commented Feb 15, 2024

I've removed the SDK2 references

@oneVR
Copy link
Owner

oneVR commented Feb 15, 2024

I've removed the SDK2 references

Thank you for the PR @hai-vr ! I didn't see anything else that would be a problem so I'll look into merging it later this week.

@oneVR oneVR merged commit d1cf992 into oneVR:vpm Feb 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants