Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MAINT: updated github PR templates #2828

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

samir-nasibli
Copy link
Contributor

@samir-nasibli samir-nasibli commented Jun 25, 2024

Changes:

  • new template
  • PR checklist job which fails if PR is not draft and hasn't all closed check boxes

New template

Description

Add a comprehensive description of proposed changes

List associated issue number(s) if exist(s): #6 (for example)

Documentation PR (if needed): #1340 (for example)

Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@samir-nasibli samir-nasibli marked this pull request as ready for review September 18, 2024 23:19
@samir-nasibli samir-nasibli added the docs Issue/PR related to oneDAL docs label Sep 18, 2024
@samir-nasibli
Copy link
Contributor Author

hm, I didn't expect that doc update will trigger jobs for library build and tests. Should be fixed

@Alexsandruss Alexsandruss merged commit f0790c4 into oneapi-src:main Sep 30, 2024
6 of 18 checks passed
@samir-nasibli samir-nasibli deleted the maint/pr_template branch September 30, 2024 09:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs Issue/PR related to oneDAL docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants