Skip to content

Clarify device query partition enumerations. #552

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
veselypeta opened this issue May 30, 2023 · 1 comment
Closed

Clarify device query partition enumerations. #552

veselypeta opened this issue May 30, 2023 · 1 comment
Labels
specification Changes or additions to the specification
Milestone

Comments

@veselypeta
Copy link
Contributor

Some UR enumerations are perhaps confusingly named and do not return the expected type as to what their name might suggest.

The two queries:

  • UR_DEVICE_INFO_PARTITION_PROPERTIES: which is equivalent to CL_DEVICE_PARTITION_PROPERTIES and returns an array of ur_device_partition_type_t which indicates what partition schemes are supported by the device. In OpenCL this returns a cl_device_partition_property[] which is just an array of intptr, but makes sense to call this enum *_PROPERTIES. However in UR we have a specific enum for these values so we should rename this enumeration perhaps to UR_DEVICE_INFO_PARTITION_TYPES
  • UR_DEVICE_INFO_PARTITION_TYPE: is a query which returns the partition type of a sub-device. I.e. The properties passed to urDevicePartition as a ur_device_partition_property_t[]. However, this name will now be confusing with the suggestion of renaming of UR_DEVICE_INFO_PARTITION_PROPERTIES. We should rename this enum to disambiguate between the two enumerations.
@veselypeta veselypeta added the specification Changes or additions to the specification label May 30, 2023
@veselypeta
Copy link
Contributor Author

veselypeta commented May 30, 2023

This was completed as part of #536

@kbenzie kbenzie added this to the 0.7 milestone Aug 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
specification Changes or additions to the specification
Projects
None yet
Development

No branches or pull requests

2 participants