[UR] Refactor urDevicePartition to use desc struct #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
force-pushed
the
petr/device-partition-properties
branch
from
f907ba0 to
a6c08a3
Compare
veselypeta
force-pushed
the
petr/device-partition-properties
branch
from
a6c08a3 to
5ebf643
Compare
pbalcer
approved these changes
May 24, 2023
kbenzie
reviewed
May 24, 2023
|
I agree with Bennie's suggestion. But looks good to me otherwise 👍 |
fabiomestre
approved these changes
May 24, 2023
pbalcer
approved these changes
May 25, 2023
veselypeta
force-pushed
the
petr/device-partition-properties
branch
2 times, most recently
from
71c50a4 to
0ed16b1
Compare
veselypeta
force-pushed
the
petr/device-partition-properties
branch
from
0ed16b1 to
cf739e0
Compare
dm-vodopyanov
added a commit
to dm-vodopyanov/llvm
that referenced
this pull request
Jun 14, 2023
…RSION This should have been an obvious update of Unified Runtime sources to support UR_DEVICE_INFO_IP_VERSION, required in intel#9843, but this update brought many API breaks mostly caused by this patch: oneapi-src/unified-runtime#536
dm-vodopyanov
added a commit
to intel/llvm
that referenced
this pull request
Jun 21, 2023
…RSION (#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in #9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src/unified-runtime#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com> Co-authored-by: Callum Fare <callum@codeplay.com> Co-authored-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
…RSION (intel#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src/unified-runtime#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com> Co-authored-by: Callum Fare <callum@codeplay.com> Co-authored-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
fabiomestre
pushed a commit
to fabiomestre/llvm
that referenced
this pull request
Sep 26, 2023
…RSION (intel#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src/unified-runtime#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com> Co-authored-by: Callum Fare <callum@codeplay.com> Co-authored-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
fabiomestre
pushed a commit
to fabiomestre/unified-runtime
that referenced
this pull request
Sep 26, 2023
…RSION (#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel/llvm#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com> Co-authored-by: Callum Fare <callum@codeplay.com> Co-authored-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
fabiomestre
pushed a commit
that referenced
this pull request
Sep 27, 2023
…RSION (#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel/llvm#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: #536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com> Co-authored-by: Callum Fare <callum@codeplay.com> Co-authored-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Oct 23, 2023
…RSION (#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel/llvm#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com> Co-authored-by: Callum Fare <callum@codeplay.com> Co-authored-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Oct 23, 2023
…RSION (#9873) This should have been an obvious update of Unified Runtime tag to support UR_DEVICE_INFO_IP_VERSION, required in intel/llvm#9843 (just tag update, nothing else), but it also brought many API breaks caused by this patch: oneapi-src#536. So the current PR updates our codebase in accordance with changed UR API. --------- Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com> Co-authored-by: Callum Fare <callum@codeplay.com> Co-authored-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion on the approach can be seen in #401