Skip to content

[usm allocator] add linking with pthreads #628

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2023
Merged

[usm allocator] add linking with pthreads #628

merged 2 commits into from
Jun 16, 2023

Conversation

pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Jun 16, 2023

... and add gcc-7 build to avoid breaking it
in the future.

@pbalcer
Copy link
Contributor Author

pbalcer commented Jun 16, 2023

Context: intel/llvm#9873 (comment)

kbenzie
kbenzie approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question

pbalcer added 2 commits June 16, 2023 14:15
@pbalcer
[uma] remove unused variables from a tuple
00ef7b9
@pbalcer
[usm allocator] add linking with pthreads
4136fbb 
... and add gcc-7 build to avoid breaking it
in the future.
@pbalcer pbalcer force-pushed the disjoint-pool-gcc-7 branch from 8111990 to 4136fbb Compare June 16, 2023 12:52
@pbalcer pbalcer merged commit a81da22 into oneapi-src:main Jun 16, 2023
@jandres742
Copy link

... and add gcc-7 build to avoid breaking it in the future.

thanks @pbalcer ! yes, having gcc-7 validation added is great.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@veselypeta veselypeta veselypeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbalcer @jandres742 @kbenzie @veselypeta