feat(ingress-nginx): remove need for individual ingress annotations #8446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss annot…" This reverts commit 1a6ee27.
onedr0p
changed the title
bot-ross
bot
added
area/kubernetes
onedr0p
deleted the
revert-8445-revert-8444-revert-8443-revert-8441-no-ingress-annotations
branch
|
Worth reflecting in cluster-template? |
|
I thought about it but because it only uses external-dns for cloudflare and k8s-gateway for internal DNS it might not work. If you run this exact setup still feel free to open a PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less annotations, more wow