Fix bug where protected types appear as fields in unprotected types #7386
+110
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test case for directly and deeply nested fields for this case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7386 +/- ##
==========================================
- Coverage 41.12% 41.12% -0.01%
==========================================
Files 2206 2206
Lines 193447 193447
==========================================
- Hits 79553 79551 -2
- Misses 107268 107269 +1
- Partials 6626 6627 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tim-barry
approved these changes
May 8, 2025
AndriiDiachuk
approved these changes
May 9, 2025
zhangchiqing
approved these changes
May 9, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #7376
This PR fixes a bug reported in #7375 (comment), where a mutation-protected type is incorrectly reported by the linter when it appears as a field of a non-mutation protected type.
This PR improves the logic detecting which fields are allowed to be set to allow this case. It also extends the test cases to include this case.