Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate filters #50

Merged
merged 4 commits into from
Dec 28, 2015
Merged

Deprecate filters #50

merged 4 commits into from
Dec 28, 2015

Conversation

mvar
Copy link
Member

@mvar mvar commented Dec 21, 2015

Blocked by #48

What was done:

  • Deprecated all filters
  • Deprecated filtered query
  • Fixed range filter (parameters were added in wrong scope)
  • Fixed namespace of test classes

What should be done next:

  • Add “deprecated” in filters documentation
  • Add documentation for new queries
  • Update places where deprecated filters are used

Notes:

Deprecated classes now throws E_USER_DEPRECATED error. Because trigger_error() was used in file scope, CodeSniffer now shows warnings on these lines.

@mvar mvar added the qa label Dec 21, 2015
@saimaz
Copy link
Member

saimaz commented Dec 24, 2015

There are so many warnings from code sniffer. Is there a way to fix them?

@mvar
Copy link
Member Author

mvar commented Dec 28, 2015

I have excluded filter classes from phpcs checking. Also added change log.

saimaz added a commit that referenced this pull request Dec 28, 2015
@saimaz saimaz merged commit 3b2b7c3 into ongr-io:master Dec 28, 2015
@saimaz saimaz removed the qa label Dec 28, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants